Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB selection in JPA entity generation and improve derby integration #7246

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix DB selection in JPA entity generation and improve derby integration #7246

merged 2 commits into from
Apr 9, 2024

Conversation

matthiasblaesing
Copy link
Contributor

  • JPA: Prevent NullPointerException when checking for DB connection for JakartaEE server
  • Enable starting older derby versions on new JVMs and support derby JDBC driver for derby >= 10.15
    • derby versions before 10.15 try to set the security manager for the JVM when they start the network server. On JDK > 17 this fails and the failure is silent (no message). NetBeans has already a work around when the start raises error messages, an autodetection for the problem was added and disables the use of the security manager on JVMs > 17
    • With version 10.15 derby was made compatible with the java module system (JPMS). The required package split lead to changes in the names for the JDBC drivers.

Closes: #7225
Closes: #7035

@matthiasblaesing
Enable starting older derby versions on new JVMs and support derby JD…
81fe1f8 
…BC driver for derby >= 10.15

- derby versions before 10.15 try to set the security manager for the
  JVM when they start the network server. On JDK > 17 this fails and
  the failure is silent (no message). NetBeans has already a work
  around when the start raises error messages, an autodetection for the
  problem was added and disables the use of the security manager on
  JVMs > 17

- With version 10.15 derby was made compatible with the java module
  system (JPMS). The required package split lead to changes in the
  names for the JDBC drivers.

Closes: apache#7035
@matthiasblaesing
JPA: Prevent NullPointerException when checking for DB connection Jak…
4ac0ff8 
…artaEE server

Closes: apache#7225
@matthiasblaesing matthiasblaesing added Java EE/Jakarta EE [ci] enable enterprise job enterprise [ci] enable enterprise job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Apr 5, 2024
@matthiasblaesing matthiasblaesing added this to the NB22 milestone Apr 5, 2024
This was referenced Apr 5, 2024
Closed
Closed
@ebarboni
Copy link
Contributor

ebarboni commented Apr 9, 2024

LGTM + review on issue #7225 looks ok

@matthiasblaesing
Copy link
Contributor Author

@aubi @ebarboni thank you both for checking!

@matthiasblaesing matthiasblaesing merged commit 592124a into apache:master Apr 9, 2024
34 checks passed
@matthiasblaesing matthiasblaesing deleted the derby_jpa_integration branch April 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) enterprise [ci] enable enterprise job Java EE/Jakarta EE [ci] enable enterprise job
Projects
NetBeans JavaEE related
Status: Done
Milestone
NB22
2 participants
@matthiasblaesing @ebarboni